[Lldb-commits] [PATCH] D156493: [lldb-vsocde] Adding support for the "disassemble" request.

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added a comment.

Also it would be very useful if the logs could be printed in a pretty form like:

  >>> from pprint import pprint
  >>> pprint(j)
  {u'body': {u'instructions': [{u'address': u'0x400584',
                                u'column': 9,
                                u'instruction': u'    ldr r0, [sp, #0x4]',
                                u'instructionBytes': u'04 00 9d e5',
                                u'line': 12,
                                u'location': {u'name': u'main.c',
                                              u'path': u'/home/tcwg-buildbot/worker/lldb-arm-ubuntu/llvm-project/lldb/test/API/tools/lldb-vscode/disassemble/main.c'}},
                               {u'address': u'0x400588',
                                u'column': 16,
                                u'instruction': u'    ldr     r1, [sp]',
                                u'instructionBytes': u'00 10 9d e5',
                                u'line': 12,
                                u'location': {u'name': u'main.c',
                                              u'path': u'/home/tcwg-buildbot/worker/lldb-arm-ubuntu/llvm-project/lldb/test/API/tools/lldb-vscode/disassemble/main.c'}},

Probably only want to do that when we've had a failure and not waste time otherwise, but it would be a lot more readable in the log file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156493/new/

https://reviews.llvm.org/D156493