[Lldb-commits] [PATCH] D156817: _wsopen_s does not accept bits other than `_S_IREAD | _S_IWRITE`

David Spickett via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 2 01:31:27 PDT 2023


DavidSpickett added inline comments.


================
Comment at: lldb/source/Host/windows/FileSystem.cpp:104
     return -1;
+  mode = mode & (_S_IREAD | _S_IWRITE); // All other bits are rejected by _wsopen_s
   int result;
----------------
Nitpick: comments are usually on the line before.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156817/new/

https://reviews.llvm.org/D156817



More information about the lldb-commits mailing list