[Lldb-commits] [PATCH] D156732: Display PC instead of <unknown> for stack trace in vscode

[jeffrey tan via Phabricator via lldb-commits]

yinghuitan added a comment.

Can you add a testcase for this?



================
Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:768
+    // hex string.
+    frame_name.clear();
+    llvm::raw_string_ostream os(frame_name);
----------------
I do not think this is needed? 


================
Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:771
+    os << llvm::format_hex(frame.GetPC(), 18);
+    os.flush();
+  }
----------------
I do not think `os.flush()` is needed. `llvm::raw_string_ostream` should auto flush while running out of scope.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156732/new/

https://reviews.llvm.org/D156732