[Lldb-commits] [PATCH] D156774: [WIP][lldb] Parse enums while parsing a type

Mon Jul 31 23:28:33 PDT 2023

Endill added inline comments.

================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3043
+      SymbolContextScope *scope;
+      scope = parent_die.GetDWARF()->GetObjectFile()->GetModule().get();
+      assert(scope);
----------------
I've used https://github.com/llvm/llvm-project/blob/fa2b038cadf17d08014e5fb75c47b5024860953e/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp#L2689 as a reference, and I guess I'm missing CompileUnit counterpart of this. Surprisingly to me, even with CompileUnit part missing, I was able to debug a Clang crash successfully.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156774/new/

https://reviews.llvm.org/D156774