[Lldb-commits] [PATCH] D156562: [lldb] Clean up uses of UuidCompatibility.h

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 28 15:14:21 PDT 2023

bulbazord added a comment.

In D156562#4543743 <https://reviews.llvm.org/D156562#4543743>, @jasonmolenda wrote:

> This is fine to me but maybe instead of `ifndef apple` we could do a `if __has_include(<uuid/uuid.h>)` and include the system header if it's avail.  I must be misreading the patch but it seems like you're changing the filename to AppleUuidCompatbility.h but the two places it's included still call it UuidCompatibility.h.

You're not reading it wrong, that was just my mistake. I built this on a Darwin machine so that codepath never ran... Good catch!

> The uuid_is_null is probably my fault, I think I had something that I had a uuid_t that I didn't want to turn in to a "valid" UUID object when I assigned the bytes, and either I misunderstood the contract or I used the wrong one and once I fixed that, I didn't need the test any more.

Thanks for the context 👍

  rG LLVM Github Monorepo



More information about the lldb-commits mailing list