[Lldb-commits] [PATCH] D156562: [lldb] Clean up uses of UuidCompatibility.h

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 28 12:35:47 PDT 2023

bulbazord added inline comments.

Comment at: lldb/include/lldb/Utility/AppleUuidCompatibility.h:15
 // uuid_t is guaranteed to always be a 16-byte array
 typedef unsigned char uuid_t[16];
 #endif // utility_UUID_COMPATIBILITY_H
mib wrote:
> May be this could be moved to `lldb-types.h` (if it's even used) so we can remove the whole file ?
I thought about this but I went with this as a safer option. I'm not sure what definition of `uuid_t` other platforms provide (hopefully the same but I haven't verified). We really only use this definition in two places: ObjectFileMachO and DynamicLoaderMacOSXDYLD. In those places, we just need a compatible definition of `uuid_t`. Putting it in `lldb-types.h` would mean we would get that definition everywhere (even if it was already provided by the underlying system, excluding Darwin).

  rG LLVM Github Monorepo



More information about the lldb-commits mailing list