[Lldb-commits] [PATCH] D156483: [lldb] Support CTF forward declarations

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jul 27 13:59:56 PDT 2023


bulbazord added a comment.

Looks like a straightforward follow-up to D156447 <https://reviews.llvm.org/D156447>. One small nit but otherwise looks good.



================
Comment at: lldb/source/Plugins/SymbolFile/CTF/SymbolFileCTF.cpp:530
+  CompilerType forward_compiler_type = m_ast->CreateRecordType(
+      nullptr, OptionalClangModuleID(), eAccessPublic, ctf_forward.name.data(),
+      clang::TTK_Struct, eLanguageTypeC);
----------------
It takes a StringRef directly, no need to yoink out the pointer and re-create it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156483/new/

https://reviews.llvm.org/D156483



More information about the lldb-commits mailing list