[Lldb-commits] [PATCH] D156447: [lldb] Split CTF parsing and type creation (NFC)

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere marked 4 inline comments as done.
JDevlieghere added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/CTF/CTFTypes.h:101
+  struct Value {
+    Value(llvm::StringRef name, uint32_t value) : name(name), value(value){};
+    llvm::StringRef name;
----------------
bulbazord wrote:
> 
Clang format actually insists on this to fit it on one line.


================
Comment at: lldb/source/Plugins/SymbolFile/CTF/SymbolFileCTF.cpp:931
 
-void SymbolFileCTF::AddTypeForUID(lldb::user_id_t type_uid, lldb::TypeSP type) {
-  assert(type_uid == m_types.size() + 1);
-  m_types.emplace_back(type);
-}
+lldb_private::Type *SymbolFileCTF::ResolveTypeUID(lldb::user_id_t type_uid) {
+  auto find_result = m_types.find(type_uid);
----------------
bulbazord wrote:
> Why do we return a `Type *` instead of a `TypeSP`?
The base method this overrides returns a `Type*`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156447/new/

https://reviews.llvm.org/D156447