[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Sat Jul 22 03:33:31 PDT 2023

Michael137 added inline comments.

================
Comment at: lldb/include/lldb/Target/Platform.h:492
+  static llvm::Expected<SDKPathSearchResult>
+  GetSDKPathFromDebugInfo(Module &module);
+
----------------
Michael137 wrote:
> I'm open to suggestions on where to put this API. `Platform` seems a bit too generic. But the intention is to share it with the Swift plugin. I could put it into `PlatformDarwin`.
See how I intend to use it from the Swift plugin [[ https://github.com/apple/llvm-project/pull/7094/files#diff-35515cd82b78e2f7bbeff1d175f83a9dbe48066615f29cd377bd9cbf4591cb70 | here ]]

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156020/new/

https://reviews.llvm.org/D156020