[Lldb-commits] [PATCH] D155768: [lldb] [NFC] Remove some dead code from Watchpoint class, and a method that makes no sense

David Spickett via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jul 20 02:00:03 PDT 2023


DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.

I don't understand the logic for if the hit counter is < the number of false alarms. I'm not even sure that's possible given that a false alarm would have to come from a reported hit, wouldn't it?

Maybe there is a behaviour difference when using UndohitCount but I don't think it's worth worrying about. LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155768/new/

https://reviews.llvm.org/D155768



More information about the lldb-commits mailing list