[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

[Alex Langford via Phabricator via lldb-commits]

bulbazord added a comment.

I'm good with this approach. One thing to note is that this change is explicitly **ABI breaking**. Specifically this change removes `lldb::ScriptedObject` so `SBProcess::GetScriptedImplementation`'s return value changes. `lldb::ScriptedObject` was originally added in February 2023 (see: `c1928033047409f977b26ffc938d59188f1ced97`) so this has not made it into an LLDB release so far. Even though this does break ABI, from a release perspective this should be okay to do since it's technically additive when compared to the previous release.

I'll defer to @JDevlieghere for approval.



================
Comment at: lldb/bindings/python/python-typemaps.swig:127-135
+  $result = nullptr;
+  if (const void* impl = $1.ptr)
+    $result = (PyObject*) impl;
+  if (!$result) {
+    $result = Py_None;
+    Py_INCREF(Py_None);
+  } else {
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155161/new/

https://reviews.llvm.org/D155161