[Lldb-commits] [PATCH] D155256: Add fs_base/gs_base support for Linux

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added a comment.

Caveat: I have 0 prior knowledge about these registers.

What's the testing story here? I see one for fs_base on a live process but none for gs_base and neither for core files. If one test can hit all the code paths those would hit, then fine, but otherwise this needs more coverage.

Side note: please put a tag in the commit title like `[lldb][x86] ...`. It helps people like me who skim through the logs looking for build problems later.



================
Comment at: lldb/source/Plugins/Process/Utility/RegisterInfos_x86_64_with_base.h:71
+                                 {kind1, kind2, kind3, kind4,                  \
+                                  x86_64_with_base::lldb_##reg },                       \
+                                  nullptr, nullptr, nullptr,                   \
----------------
Has this file been put through clang-format? These lines look off.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155256/new/

https://reviews.llvm.org/D155256