[Lldb-commits] [PATCH] D155107: Add support for llvm::MCInstPrinter::setPrintBranchImmAsAddress

Jason Molenda via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sun Jul 16 20:36:57 PDT 2023


jasonmolenda added a comment.

Isn't it better to print branches within a function as an offset, given that our disassembly format by default lists the offset of each instruction.  So instead of looking for a 6-digit long hex address, you're looking for a decimal offset in the output?  I'm not sure if you disagree with my opinion, or if you have an example where it is clearer to have an address that I'm not seeing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155107/new/

https://reviews.llvm.org/D155107



More information about the lldb-commits mailing list