[Lldb-commits] [PATCH] D155333: [lldb][LocateModuleCallback] Fix FileSpec compare

Fri Jul 14 18:39:51 PDT 2023

jasonmolenda added a comment.

FWIW when I was testing this locally, I was seeing paths like

  (lldb) p uuid_view
  (lldb_private::FileSpec) $0 = file: "AndroidModule.so" dir: "/var/folders/1b/976z5_5513l64wvrj15vkt800000gn/T/lldb/49966/LocateModuleCallbackTest-GetOrCreateModuleWithCachedModuleAndSymbol/remote-android/.cache/80008338-82A0-51E5-5922-C905D23890DA-BDDEFECC"

  (lldb) p module_sp->GetFileSpec()
  (const lldb_private::FileSpec) $1 = file: "AndroidModule.so" dir: "/var/folders/1b/976z5_5513l64wvrj15vkt800000gn/T/lldb/49966/LocateModuleCallbackTest-GetOrCreateModuleWithCachedModuleAndSymbol/remote-android/.cache/80008338-82A0-51E5-5922-C905D23890DA-BDDEFECC"

and I'm betting the real issue is that the arm64 bot account has something funky about TMPRDIR, so one of these is realpath'ed to a different filepath and the comparison failed.  It would be a lot easier to understand what was actually happening on that bot if we could see the paths, but I don't think we're addressing the actual issue here.  (we need to fix the printing first, then we can see what is going on with the bot)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155333/new/

https://reviews.llvm.org/D155333