[Lldb-commits] [PATCH] D155333: [lldb][LocateModuleCallback] Fix FileSpec compare

Jason Molenda via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 14 18:03:53 PDT 2023


jasonmolenda added a comment.

My first thought was, but what about all the other unit tests doing this, and git grepping around, I think there's one in Interpreter/TestOptionValue.cpp and one in Interpreter/TestOptionValueFileColonLine.cpp.   I'd like to see what @JDevlieghere thinks, this patch is fine to me but it is an unfortunate - surely there is some method we could implement in FileSpec to get the gtest stuff to print the path when there's a failure, but I didn't see it when I tried to read through the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155333/new/

https://reviews.llvm.org/D155333



More information about the lldb-commits mailing list