[Lldb-commits] [lldb] ce22598 - Disable GetOrCreateModuleWithCachedModule and GetOrCreateModuleWithCachedModuleAndSymbol tests on arm64, because of test failures
Shubham Sandeep Rastogi via lldb-commits
lldb-commits at lists.llvm.org
Fri Jul 14 10:41:55 PDT 2023
Author: Shubham Sandeep Rastogi
Date: 2023-07-14T13:41:27-04:00
New Revision: ce225982af734bdb68dc054017fc4411c179591c
URL: https://github.com/llvm/llvm-project/commit/ce225982af734bdb68dc054017fc4411c179591c
DIFF: https://github.com/llvm/llvm-project/commit/ce225982af734bdb68dc054017fc4411c179591c.diff
LOG: Disable GetOrCreateModuleWithCachedModule and GetOrCreateModuleWithCachedModuleAndSymbol tests on arm64, because of test failures
Added:
Modified:
lldb/unittests/Target/LocateModuleCallbackTest.cpp
Removed:
################################################################################
diff --git a/lldb/unittests/Target/LocateModuleCallbackTest.cpp b/lldb/unittests/Target/LocateModuleCallbackTest.cpp
index 42a0790bca58f2..ad96adb32a471a 100644
--- a/lldb/unittests/Target/LocateModuleCallbackTest.cpp
+++ b/lldb/unittests/Target/LocateModuleCallbackTest.cpp
@@ -263,6 +263,11 @@ class LocateModuleCallbackTest : public testing::Test {
} // namespace
TEST_F(LocateModuleCallbackTest, GetOrCreateModuleWithCachedModule) {
+ // Disable test on arm64 because of failures in the lldb incremental arm64
+ // bot.
+#if defined(__arm64__) || defined(__aarch64__) || defined(_M_ARM64)
+ GTEST_SKIP() << "broken on arm64.";
+#endif
// The module file is cached, and the locate module callback is not set.
// GetOrCreateModule should succeed to return the module from the cache.
FileSpec uuid_view = BuildCacheDir(m_test_dir);
@@ -281,6 +286,12 @@ TEST_F(LocateModuleCallbackTest, GetOrCreateModuleWithCachedModuleAndSymbol) {
// The module and symbol files are cached, and the locate module callback is
// not set. GetOrCreateModule should succeed to return the module from the
// cache with the symbol.
+
+ // Disable test on arm64 because of failures in the lldb incremental arm64
+ // bot.
+#if defined(__arm64__) || defined(__aarch64__) || defined(_M_ARM64)
+ GTEST_SKIP() << "broken on arm64.";
+#endif
FileSpec uuid_view = BuildCacheDirWithSymbol(m_test_dir);
CheckNoCallback();
@@ -642,4 +653,4 @@ TEST_F(LocateModuleCallbackTest,
ModuleSP module_sp =
m_target_sp->GetOrCreateModule(m_module_spec, /*notify=*/false);
ASSERT_FALSE(module_sp);
-}
+}
\ No newline at end of file
More information about the lldb-commits
mailing list