[Lldb-commits] [PATCH] D155124: [lldb][Windows] Fix TestLocateModuleCallback
Kazuki Sakamoto via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Jul 14 10:41:14 PDT 2023
This revision was automatically updated to reflect the committed changes.
Closed by commit rG43b9d62018fe: [lldb][Windows] Fix TestLocateModuleCallback (authored by splhack).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155124/new/
https://reviews.llvm.org/D155124
Files:
lldb/test/API/python_api/sbplatform/TestLocateModuleCallback.py
Index: lldb/test/API/python_api/sbplatform/TestLocateModuleCallback.py
===================================================================
--- lldb/test/API/python_api/sbplatform/TestLocateModuleCallback.py
+++ lldb/test/API/python_api/sbplatform/TestLocateModuleCallback.py
@@ -49,7 +49,9 @@
self.assertEqual(MODULE_TRIPLE, module_spec.GetTriple())
- self.assertEqual(MODULE_PLATFORM_PATH, module_spec.GetFileSpec().fullpath)
+ self.assertEqual(
+ MODULE_PLATFORM_PATH, Path(module_spec.GetFileSpec().fullpath).as_posix()
+ )
def check_module(self, module: lldb.SBModule, symbol_file: str, symbol_kind: str):
self.assertTrue(module.IsValid())
@@ -61,16 +63,20 @@
self.assertEqual(MODULE_RESOLVED_TRIPLE, module.GetTriple())
- self.assertEqual(MODULE_PLATFORM_PATH, module.GetPlatformFileSpec().fullpath)
-
self.assertEqual(
- str(self.input_dir / MODULE_FILE),
- module.GetFileSpec().fullpath,
+ MODULE_PLATFORM_PATH, Path(module.GetPlatformFileSpec().fullpath).as_posix()
)
- self.assertEqual(
- str(self.input_dir / symbol_file),
- module.GetSymbolFileSpec().fullpath,
+ self.assertTrue(
+ (self.input_dir / MODULE_FILE)
+ .resolve()
+ .samefile(Path(module.GetFileSpec().fullpath).resolve())
+ )
+
+ self.assertTrue(
+ (self.input_dir / symbol_file)
+ .resolve()
+ .samefile(Path(module.GetSymbolFileSpec().fullpath).resolve())
)
sc_list = module.FindFunctions(MODULE_FUNCTION, lldb.eSymbolTypeCode)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155124.540491.patch
Type: text/x-patch
Size: 1674 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230714/b0bb93d4/attachment-0001.bin>
More information about the lldb-commits
mailing list