[Lldb-commits] [PATCH] D153734: [lldb][LocateModuleCallback] Call locate module callback

Shubham Sandeep Rastogi via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 14 08:47:51 PDT 2023


rastogishubham added a comment.

In D153734#4501034 <https://reviews.llvm.org/D153734#4501034>, @rastogishubham wrote:

> I am reverting both fb087c17c8230 <https://reviews.llvm.org/rGfb087c17c82309404fe0ebf3505c186642a719f7> and 7f1028e9df52b <https://reviews.llvm.org/rG7f1028e9df52b4e7246f189a24684b1ca8c9bfbe> to see if the bot becomes green again. I apologize for any incovenience

Okay, so reverting those two changes cause other build failures, and I don't think it is a good idea to revert a bunch of changes, I am not sure what a good way to disable the test for arm64 is? Since these failures only appear on arm64

Would it be just adding a

  #if !defined(__aarch64__)

to the top of the file work?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153734/new/

https://reviews.llvm.org/D153734



More information about the lldb-commits mailing list