[Lldb-commits] [PATCH] D149213: [lldb] Add basic support to Rust enums in TypeSystemClang
Vladimir Makaev via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Jul 13 19:21:40 PDT 2023
VladimirMakaev updated this revision to Diff 540251.
VladimirMakaev added a comment.
Herald added a reviewer: sscalpone.
Rebased on master (this diff was quite a bit old)
Addressed review comments
- renamed method to ParseRustVariantPart
- added CU check
- added a good bunch of test covering cases I could think of using global variabes.
- 2 tests for Option<NonNull<T>> couldn't be done with globals due to Rust compiler strictness on UBs. Was able to create SBValue based on raw data
- addressed VariantMember::GetName()
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149213/new/
https://reviews.llvm.org/D149213
Files:
lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h
lldb/test/API/lang/rust/enum-structs/RustEnumValue.py
lldb/test/API/lang/rust/enum-structs/TestRustEnumStructs.py
lldb/test/API/lang/rust/enum-structs/main.rs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149213.540251.patch
Type: text/x-patch
Size: 28275 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230714/093fd589/attachment-0001.bin>
More information about the lldb-commits
mailing list