[Lldb-commits] [PATCH] D155178: [Support] Move StringExtras.h include from Error.h to Error.cpp (part 6)

Thu Jul 13 14:51:42 PDT 2023

MaskRay added a comment.

In D155178#4499105 <https://reviews.llvm.org/D155178#4499105>, @MaskRay wrote:

> In D155178#4498911 <https://reviews.llvm.org/D155178#4498911>, @thakis wrote:
>
>> http://45.33.8.238/linux/112305/step_4.txt looks like a missing include
>
> I've fixed it in 816141ce0eb899178dbcb6f0671875eb825b2f84 <https://reviews.llvm.org/rG816141ce0eb899178dbcb6f0671875eb825b2f84> but it seems that the current build strategy of llvm-debuginfod makes it error-prone for refactoring. @mysterymath  @phosek

Actually I am unable to figure out how to get brotli cmake files. I relied on gn to test my fix:)

  llvm/utils/gn/gn.py gen /tmp/out/gn
  ninja -C /tmp/out/gn llvm-debuginfod

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155178/new/

https://reviews.llvm.org/D155178