[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/source/API/SBStructuredData.cpp:51-53
+                                         const lldb::SBDebugger &debugger) {
+  return debugger.CreateStructuredDataFromScriptObject(obj);
+}
----------------
mib wrote:
> bulbazord wrote:
> > I already asked why this is necessary, but if it does stick around you'll want to add `LLDB_INSTRUMENT_VA` here too yeah?
> This is a `static` method and I don't think we call `LLDB_INSTRUMENT_VA` in that case. Might be wrong though @JDevlieghere ?
We do, see `SBDebugger::Create` for example. we just don't pass `this`. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155161/new/

https://reviews.llvm.org/D155161