[Lldb-commits] [PATCH] D153735: [lldb][LocateModuleCallback] Implement API, Python interface

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda added a comment.

@splhack the shell tests are all asserting on Darwin systems (on my desktop and on the bots https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ https://green.lab.llvm.org/green/view/LLDB/job/as-lldb-cmake/ ):

  [ RUN      ] LocateModuleCallbackTest.GetOrCreateModuleCallbackSuccessWithModuleAndBreakpadSymbol
  Assertion failed: (default_platform_sp), function Debugger, file Debugger.cpp, line 837.
  Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
  0  TargetTests              0x000000010048a5b0 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 80
  1  TargetTests              0x000000010048ab4c PrintStackTraceSignalHandler(void*) + 28
  2  TargetTests              0x000000010048887c llvm::sys::RunSignalHandlers() + 152
  3  TargetTests              0x000000010048bd08 SignalHandler(int) + 276
  4  libsystem_platform.dylib 0x0000000183a65a24 _sigtramp + 56
  5  libsystem_pthread.dylib  0x0000000183a36cc0 pthread_kill + 288
  6  libsystem_c.dylib        0x0000000183946a80 abort + 180
  7  libsystem_c.dylib        0x0000000183945d9c err + 0
  8  TargetTests              0x000000010050afa0 lldb_private::Debugger::Debugger(void (*)(char const*, void*), void*) + 1700
  9  TargetTests              0x0000000100509be8 lldb_private::Debugger::Debugger(void (*)(char const*, void*), void*) + 44
  10 TargetTests              0x0000000100509b10 lldb_private::Debugger::CreateInstance(void (*)(char const*, void*), void*) + 68
  11 TargetTests              0x00000001001e9434 (anonymous namespace)::LocateModuleCallbackTest::SetUp() + 124

In these tests,

     835 	  // Always add our default platform to the platform list
  -> 836 	  PlatformSP default_platform_sp(Platform::GetHostPlatform());
     837 	  assert(default_platform_sp);
     838 	  m_platform_list.Append(default_platform_sp, true);

`Platform::GetHostPlatform()` is returning no platform.  I don't know the contracts for this call offhand and if there might be an issue with how the debugger was created that is causing this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153735/new/

https://reviews.llvm.org/D153735