[Lldb-commits] [PATCH] D155037: Improve error messaging when debugserver fails to complete attaching to another process on Darwin systems

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda updated this revision to Diff 539719.
jasonmolenda added a comment.

Update to incorporate Jonas' suggestion - adding MachProcess::GetParentProcessID and MachProcess::ProcessIsBeingDebugged, as well as the DNB passthrough functions.  I didn't pass back optionals for the cases were we can fail, using "invalid pid number" and "is not being debugged" for when the calls fail, which isn't the correctest but these are only ending up in error messages so i'm not too pressed about it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155037/new/

https://reviews.llvm.org/D155037

Files:
  lldb/include/lldb/Symbol/UnwindPlan.h
  lldb/source/Commands/CommandObjectTarget.cpp
  lldb/source/Plugins/UnwindAssembly/x86/x86AssemblyInspectionEngine.cpp
  lldb/source/Symbol/UnwindPlan.cpp
  lldb/source/Target/RegisterContextUnwind.cpp
  lldb/tools/debugserver/source/DNB.cpp
  lldb/tools/debugserver/source/DNB.h
  lldb/tools/debugserver/source/MacOSX/MachProcess.h
  lldb/tools/debugserver/source/MacOSX/MachProcess.mm
  lldb/tools/debugserver/source/RNBRemote.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155037.539719.patch
Type: text/x-patch
Size: 19424 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230712/2e5f14b0/attachment-0001.bin>