[Lldb-commits] [PATCH] D149213: [lldb] Add basic support to Rust enums in TypeSystemClang

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

In D149213#4491594 <https://reviews.llvm.org/D149213#4491594>, @bulbazord wrote:

> I'm curious to know why you don't try and implement some kind of `TypeSystemRust`? I assume it's going to be a lengthy process, but eventually you (or somebody else) is going to want to implement a `TypeSystemRust` in some form and they'll have to revisit all of rust-specific things we've tacked onto various parts of LLDB (e.g. this functionality with DWARFASTParserClang). I suppose the question I'm trying to answer is "How much do we add to LLDB before actually adding proper rust support?"

Yes this is a work around until a proper TypeSystemRust is created. It works for most things now and this will help enums work using TypeSystemClang.

> I was also curious about the test. I'm not sure how the test is supposed to work here, is the rust source file actually built or is that just to show how the yaml file was generated? There's no rust support in our testing infrastructure AFAICT so I assume this just makes sure that something already generated doesn't get broken in the future.

The yaml generates the binary so no rust compiler or anything is needed for the test. I suggested to use a yaml file that has global variables with all of the enum types so we can test the SBValue system out to ensure it is working as expected.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149213/new/

https://reviews.llvm.org/D149213