[Lldb-commits] [PATCH] D153734: [lldb][LocateModuleCallback] Call locate module callback

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: lldb/include/lldb/Target/Platform.h:884-887
+  typedef std::function<Status(const ModuleSpec &module_spec,
+                               FileSpec &module_file_spec,
+                               FileSpec &symbol_file_spec)>
+      LocateModuleCallback;
----------------
I think we still need a baton for the callback so clients can register a callback + void *.


================
Comment at: lldb/include/lldb/Target/Platform.h:944
   const std::unique_ptr<ModuleCache> m_module_cache;
+  LocateModuleCallback m_locate_module_callback;
 
----------------
We probably need a baton still. In order to make this work for python, we need to be able to set a callback and a baton for the python callable?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153734/new/

https://reviews.llvm.org/D153734