[Lldb-commits] [PATCH] D149213: [lldb] Add basic support to Rust enums in TypeSystemClang

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

Overall this looks fine as a way to help rust users see rust enums without having to implement a new TypeSystem for rust. I would just ask that we check the language of the CU before calling the ParseVariantPart, so that this would only get enabled for Rust.



================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3184
+    case DW_TAG_variant_part:
+      ParseVariantPart(die, parent_die, class_clang_type, default_accessibility,
+                       layout_info);
----------------
I would add a check here for the Rust language. We might also want to rename "ParseVariantPart" to "ParseRustVariant" to indicate this is specific to the Rust language.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149213/new/

https://reviews.llvm.org/D149213