[Lldb-commits] [PATCH] D155018: [Support] Move StringExtras.h include from Error.h to Error.cpp (part 5)

Elliot Goodrich via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 11 14:36:01 PDT 2023


IncludeGuardian added inline comments.
Herald added a subscriber: JDevlieghere.


================
Comment at: lldb/tools/lldb-vscode/VSCode.cpp:17
 #include "llvm/Support/FormatVariadic.h"

 #if defined(_WIN32)
 #define NOMINMAX
----------------
This should be the final failure on the last time landing the `Error.h` change to `main` https://lab.llvm.org/buildbot#builders/68/builds/55847


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155018/new/

https://reviews.llvm.org/D155018



More information about the lldb-commits mailing list