[Lldb-commits] [PATCH] D154992: Add a generic Process method to dump plugin history

[Jim Ingham via Phabricator via lldb-commits]

jingham created this revision.
jingham added reviewers: jasonmolenda, JDevlieghere.
Herald added a project: All.
jingham requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

I need to dump the gdb-remote communication history when we fail the "stepping or not" assertion Jason added to StopInfoMachException a week or so ago.  But that's a feature of GDBRemoteCommunication, or at best ProcessGDBRemote, and it really doesn't make sense to include that in StopInfoMachException.

However the notion of "dumping the low level plugin history for a process" seems like a generally useful one.  So I made a Process API for this, and then routed the other uses through that, and added dumping this when the assert is triggered.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D154992

Files:
  lldb/include/lldb/Target/Process.h
  lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154992.539200.patch
Type: text/x-patch
Size: 4141 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230711/e892cac8/attachment.bin>