[Lldb-commits] [PATCH] D154759: [lldb][NFCI] Change type of UnwindPlan::m_source_name

Mon Jul 10 16:52:06 PDT 2023

jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.

I'm fine with this.  It does increase the size of the UnwindPlan object, and there are a couple of them for every function that we see on a stack during a program execution, but I believe that won't be more than a few hundred.  These are short strings so they won't expand to use heap, they will fit inline.  Strictly I think it is more memory efficient to leave these half-dozen strings in the constant string pool than to have an extra 24 bytes in each UnwindPlan with them duplicated, but it's not enough memory use for me to be actually worried about it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154759/new/

https://reviews.llvm.org/D154759