[Lldb-commits] [PATCH] D154542: Further refinements on reporting interruption in lldb

[Jim Ingham via Phabricator via lldb-commits]

jingham added inline comments.


================
Comment at: lldb/include/lldb/Core/Debugger.h:455-456
+    InterruptionReport(std::string function_name, std::string description) :
+        m_function_name(function_name), 
+        m_description(description),
+        m_interrupt_time(std::chrono::system_clock::now()),
----------------
bulbazord wrote:
> To avoid some unnecessary copies
> 
> Could also do what Ismail is suggesting.
This is a local that is copied to an ivar and never used again.  Do I really have to put move in there explicitly for the optimizer to know it can reuse the value?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154542/new/

https://reviews.llvm.org/D154542