[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

[John Harrison via Phabricator via lldb-commits]

ashgti added inline comments.


================
Comment at: lldb/tools/lldb-vscode/JSONUtils.h:239
+///     useful to ensure the same column provided by the setBreakpoints request
+///     are returned to the IDE as a fallback.
 ///
----------------
DavidSpickett wrote:
> Appears that this got clang-formatted accidentally. Formatting it is fine but put it in an NFC change if you're gonna do that.
> 
> If you aren't already using it, the clang-format-diff script will help you limit formatting to only what you've edited (with occasional extra bits): https://clang.llvm.org/docs/ClangFormat.html
I had another commit (https://reviews.llvm.org/D154029) that touched this area of the code so I think thats how this snuck in. Reverted this change.


================
Comment at: lldb/tools/lldb-vscode/VSCode.cpp:797
+    g_vsc.repl_mode = ReplMode::Variable;
+    result.AppendMessage("lldb-vscode repl-mode variable set.");
+  } else if (new_mode == "command") {
----------------
DavidSpickett wrote:
> There is AppendMessageWithFormat that you could use to avoid repeating the string here.
Do you mean Printf? Switched to that instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154030/new/

https://reviews.llvm.org/D154030