[Lldb-commits] [PATCH] D154542: Further refinements on reporting interruption in lldb

[Jim Ingham via Phabricator via lldb-commits]

jingham created this revision.
jingham added reviewers: JDevlieghere, mib, bulbazord, labath.
Herald added a project: All.
jingham requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

This  patch enhances the interruption features I added a little while back.  There are two main changes.  The main one here is that I made a nicer interface to reporting interruption events.  I also added a way to ask a debugger if it was using a Module, so that we can query for interruption in Module code where we don't have access to a debugger.  I used that to support interrupting debug info reading on a per-module basis - since that's a long-running but - at least on a module boundary - resumable operation.

The current method of checking "Does this module one belong to a debugger requesting interruption" is quick and dirty here.  IMO, a better solution would be to have Modules keep a list of the Debuggers (or maybe Targets) using them.  But we should figure out all the ways we want to use that and design something nice for the purpose.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D154542

Files:
  lldb/include/lldb/Core/Debugger.h
  lldb/include/lldb/Target/TargetList.h
  lldb/source/API/SBFrame.cpp
  lldb/source/Commands/CommandCompletions.cpp
  lldb/source/Commands/CommandObjectFrame.cpp
  lldb/source/Commands/CommandObjectTarget.cpp
  lldb/source/Commands/CommandObjectThread.cpp
  lldb/source/Core/Debugger.cpp
  lldb/source/Core/Module.cpp
  lldb/source/Interpreter/CommandInterpreter.cpp
  lldb/source/Target/StackFrameList.cpp
  lldb/source/Target/Target.cpp
  lldb/source/Target/TargetList.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154542.537471.patch
Type: text/x-patch
Size: 25463 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230705/85422667/attachment-0001.bin>