[Lldb-commits] [PATCH] D154534: [lldb][NFCI] Minor cleanups to StructuredData::GetObjectForDotSeparatedPath

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jul 5 11:29:18 PDT 2023


bulbazord added inline comments.


================
Comment at: lldb/source/Utility/StructuredData.cpp:120
+    return value->GetObjectForDotSeparatedPath(match.second);
+  } else if (GetType() == lldb::eStructuredDataTypeArray) {
     std::pair<llvm::StringRef, llvm::StringRef> match = path.split('[');
----------------
fdeazeve wrote:
> Shouldn't we remove this `else`?
Ah, the first `if` does return no matter what, so yeah this `else` isn't necessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154534/new/

https://reviews.llvm.org/D154534



More information about the lldb-commits mailing list