[Lldb-commits] [PATCH] D154530: [lldb] Fix incorrect uses of LLDB_LOG_ERROR
Alex Langford via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Jul 5 11:13:51 PDT 2023
bulbazord accepted this revision.
bulbazord added a comment.
This revision is now accepted and ready to land.
I was actually looking at this today independently, guess you beat me to the punch 😛 . LGTM modulo one comment.
================
Comment at: lldb/source/Target/Target.cpp:2413-2414
LLDB_LOG_ERROR(GetLog(LLDBLog::Target), std::move(err),
- "Unable to get persistent expression state for language {}",
+ "Unable to get persistent expression state for language {1}",
Language::GetNameForLanguageType(language));
return nullptr;
----------------
No use of `{0}` here, so we're dropping the error message from the look of it?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154530/new/
https://reviews.llvm.org/D154530
More information about the lldb-commits
mailing list