[Lldb-commits] [PATCH] D154169: add a target dump section-load-list command for inspecting the Target's SectionLoadList

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda added inline comments.


================
Comment at: lldb/source/Target/SectionLoadList.cpp:265-266
        ++pos) {
-    s.Printf("addr = 0x%16.16" PRIx64 ", section = %p: ", pos->first,
-             static_cast<void *>(pos->second.get()));
     pos->second->Dump(s.AsRawOstream(), s.GetIndentLevel(), target, 0);
----------------
mib wrote:
> Out of curiosity, why did you remove the section part ?
I was being grumpy when I saw all the fields SectionLoadList::Dump was outputting and removed one of them to make me feel better, but I have to acknowledge that seeing the actual Section* value for the section may be helpful when debugging lldb.  I'll remove this part of the change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154169/new/

https://reviews.llvm.org/D154169