[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

Ivan Hernandez via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 29 09:39:35 PDT 2023


ivanhernandez13 added inline comments.


================
Comment at: lldb/tools/lldb-vscode/VSCode.h:251-252
   /// \return
-  ///   A \a PacketStatus object indicating the sucess or failure of the
-  ///   request.
-  PacketStatus SendReverseRequest(llvm::json::Object request,
-                                  llvm::json::Object &response);
+  ///   A future that resolves to the response object indicating the sucess or
+  ///   failure of the request.
+  void SendReverseRequest(llvm::StringRef command, llvm::json::Value arguments,
----------------
nit: Could you update this comment that is no longer accurate


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153447/new/

https://reviews.llvm.org/D153447



More information about the lldb-commits mailing list