[Lldb-commits] [PATCH] D153922: [lldb] Duplicate Target::Launch resuming logic into CommandObjectPlatformProcessLaunch

[Dave Lee via Phabricator via lldb-commits]

kastiglione added inline comments.


================
Comment at: lldb/source/Commands/CommandObjectPlatform.cpp:1232
+
+        assert(launch_info.GetHijackListener());
+
----------------
DavidSpickett wrote:
> DavidSpickett wrote:
> > This assert fails on Linux. Is it necessary or should I look into why it's null here on Linux?
> > 
> > WaitForProcessToStop on down either checks that the pointer is non null before use, or substitutes in another (presumably non-null) hijacker.
> To clarify, fails while running the tests in https://reviews.llvm.org/D153636.
I included it to follow (copy) `Target::Launch`. I don't know for fact that it's needed, so +1 to removing the assert if needed for Linux.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153922/new/

https://reviews.llvm.org/D153922