[Lldb-commits] [PATCH] D153840: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate.

[David Blaikie via Phabricator via lldb-commits]

dblaikie added a comment.

I'm not sure if this is the right fix - these reads are for implementing DW_OP_deref_size, by the looks of it - so I think it does make sense that the size read is not the size of the address, but the size specified in the DW_OP_deref_size. There is a requirement that DW_OP_deref_size's size may not be larger than the system address - so maybe the input that hit this is incorrect, and lldb should've failed earlier (validating the size retrieved at line 1082 is within the bounds)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153840/new/

https://reviews.llvm.org/D153840