[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

Wed Jun 28 10:30:58 PDT 2023

kastiglione added inline comments.

================
Comment at: lldb/source/Commands/CommandObjectDWIMPrint.h:46-51
+  /// Add a hint if object description was requested, but no description
+  /// function was implemented, and dump valobj to output_stream after.
+  static void MaybeAddPoHintAndDump(ValueObject &valobj,
+                                    const DumpValueObjectOptions &dump_options,
+                                    lldb::LanguageType language, bool is_po,
+                                    Stream &output_stream);
----------------
kastiglione wrote:
> Should this hint be part of dwim-print only? At this point I see `expression` as a command you use to do exactly what you ask it to do.
I see you asked this same question, and I had missed it at first.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153489/new/

https://reviews.llvm.org/D153489