[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

Wed Jun 28 01:44:27 PDT 2023

DavidSpickett added inline comments.

================
Comment at: lldb/test/API/commands/platform/process/launch/TestPlatformProcessLaunch.py:50
+        self.runCmd("settings set target.run-args D E")
+        self.runCmd("platform process launch --stdout {}".format(outfile))
+        self.runCmd("continue")
----------------
kastiglione wrote:
> kastiglione wrote:
> > @DavidSpickett did you mean for this command to use the `-s` flag too?
> I have merged D153922, which fails with this test as-is. Before re-committing, this test will need to use `-s` like the other invocations, or remove the `"continue"` command on the next line.
Will do. The missing -s was a mistake, in fact some of them failed on Linux without it. Perhaps a timing issue and I just got lucky on my local machine.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153636/new/

https://reviews.llvm.org/D153636