[Lldb-commits] [lldb] 28722dc - Summary: [lldb] Fix libncurses, libpanel library link order

[Hau Hsu via lldb-commits]

Author: Hau Hsu
Date: 2023-06-28T15:00:22+08:00
New Revision: 28722dcc2556b9cea5c7d9a4dd8343ac68e696ef

URL: https://github.com/llvm/llvm-project/commit/28722dcc2556b9cea5c7d9a4dd8343ac68e696ef
DIFF: https://github.com/llvm/llvm-project/commit/28722dcc2556b9cea5c7d9a4dd8343ac68e696ef.diff

LOG: Summary: [lldb] Fix libncurses, libpanel library link order

libpanel depends on libcurses, so when linking static libraries, libpanel
should be places prior to libcurses.

This patch resolves error like:
```
.../x86_64-centos6-linux-gnu/bin/ld:
.../lib/libpanelw.a(p_show.o):
in function `show_panel':
p_show.c:(.text+0x39): undefined reference to `_nc_panelhook_sp'
.../x86_64-centos6-linux-gnu/bin/ld:
.../lib/libpanelw.a(p_show.o):
in function `update_panels_sp':
p_update.c:(.text+0x1f): undefined reference to `_nc_panelhook_sp'
collect2: error: ld returned 1 exit status
```

Reviewed By: JDevlieghere

Differential Revision: https://reviews.llvm.org/D153844

Added: 
    

Modified: 
    lldb/source/Core/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/lldb/source/Core/CMakeLists.txt b/lldb/source/Core/CMakeLists.txt
index f5b44d3a3d73a..2de642e10e61a 100644
--- a/lldb/source/Core/CMakeLists.txt
+++ b/lldb/source/Core/CMakeLists.txt
@@ -10,7 +10,7 @@ set(LLDB_CURSES_LIBS)
 set(LLDB_LIBEDIT_LIBS)
 
 if (LLDB_ENABLE_CURSES)
-  list(APPEND LLDB_CURSES_LIBS ${CURSES_LIBRARIES} ${PANEL_LIBRARIES})
+  list(APPEND LLDB_CURSES_LIBS ${PANEL_LIBRARIES} ${CURSES_LIBRARIES})
   if(LLVM_ENABLE_TERMINFO)
     list(APPEND LLDB_CURSES_LIBS ${TERMINFO_LIB})
   endif()