[Lldb-commits] [PATCH] D153922: [lldb] Duplicate Target::Launch resuming logic into CommandObjectPlatformProcessLaunch
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Jun 27 14:40:31 PDT 2023
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
The fact that you had to duplicate code from Target::Launch means the various paths to Launching a process aren't properly factored out. However, that seems like a lot just to get Dave's fix for "platform process launch" working, so this LGTM as a short-term patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153922/new/
https://reviews.llvm.org/D153922
More information about the lldb-commits
mailing list