[Lldb-commits] [PATCH] D153867: [lldb] Use LLVM's implementation of AppleTables for apple_debug_types

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:232
+
+  llvm::StringRef expected_name = context[0].name;
+
----------------
I assume we always have at least one entry (or that's the assumption here). I was going to suggest adding an `assert` here but then I looked at the `lldb_private::DWARFDeclContext::operator[]` implementation and I think the assert should probably go there. That's orthogonal to this patch though. 


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:253-258
+  // When searching for a scoped type (for example,
+  // "std::vector<int>::const_iterator") searching for the innermost
+  // name alone ("const_iterator") could yield many false
+  // positives. By searching for the parent type ("vector<int>")
+  // first we can avoid extracting type DIEs from object files that
+  // would fail the filter anyway.
----------------
Reflow.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153867/new/

https://reviews.llvm.org/D153867