[Lldb-commits] [PATCH] D153685: [lldb] Add `source cache dump` and `source cache clear` subcommand

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere marked 4 inline comments as done.
JDevlieghere added inline comments.


================
Comment at: lldb/source/Commands/CommandObjectSource.cpp:1266
     : CommandObjectMultiword(interpreter, "source",
                              "Commands for examining "
                              "source code described by "
----------------
jasonmolenda wrote:
> Maybe we can make this less accurate and easier to understand. like "Commands for examining source files in the current process".  
But that wouldn't just be less accurate, it would be wrong. The current cache is shared across targets and processes belonging to the same debugger.


================
Comment at: lldb/source/Core/SourceManager.cpp:738
+    FileSP file = entry.second;
+    stream.Format("{0:%Y-%m-%d %H:%M:%S} {1,8:d} {2}\n", file->GetTimestamp(),
+                  file->GetNumLines(), entry.first.GetPath());
----------------
jasonmolenda wrote:
> m/d/Y would be dope tho
🇺🇸


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153685/new/

https://reviews.llvm.org/D153685