[Lldb-commits] [PATCH] D153626: [lldb] Use SmallVector for handling register data

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added a comment.

> The sanitized bot on GreenDragon runs on Intel and I assume the "risky' changes only apply to arm64 as that's the only architecture that needs to scale beyond the default 256? Anyway I haven't seen the leaks issue you've mentioned locally so I'm happy to run a sanitized build on arm64.

The risk for existing targets is that `.size()` won't reflect the size we're about to write to it. With it defaulting to 256 bytes of stack space and us using it like an array, we'd probably skip a lot of the SmallVector asserts around that.

Potentially I could "proxy" `.resize` and assert that it had been called at some point but it's still possible to forget to resize it again if it was needed. It would make more sense to look at the methods we pass the SmallVector's storage to instead. If they could take the container directly, then they could do some checks.

I will look into that, and I will also try the sanitized build again because now I wonder if lit's env cleaning was removing the options I needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153626/new/

https://reviews.llvm.org/D153626