[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

Kazuki Sakamoto via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 16 09:22:26 PDT 2023


splhack updated this revision to Diff 532196.
splhack added a comment.

- s/AdbClientSP/AdbClientUP/g
- Updated `Status &error` arg to `GetAdbClient`
- Added error checks in AndroidPlatform for `GetAdbClient`
- Added DownloadModuleSliceWithAdbClientError test for the GetAdbClient error


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152855/new/

https://reviews.llvm.org/D152855

Files:
  lldb/source/Plugins/Platform/Android/AdbClient.h
  lldb/source/Plugins/Platform/Android/PlatformAndroid.cpp
  lldb/source/Plugins/Platform/Android/PlatformAndroid.h
  lldb/unittests/Platform/Android/CMakeLists.txt
  lldb/unittests/Platform/Android/PlatformAndroidTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152855.532196.patch
Type: text/x-patch
Size: 13225 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230616/5769d552/attachment.bin>


More information about the lldb-commits mailing list