[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

Thu Jun 15 21:56:42 PDT 2023

splhack added a comment.

Verified D153091 <https://reviews.llvm.org/D153091> fixed TerminalTest failures.

from `Failed Tests (13)`
https://lab.llvm.org/buildbot/#/builders/96/builds/40769

to `Failed Tests (1)`
https://lab.llvm.org/buildbot/#/builders/96/builds/40781

will submit a diff to fix the last one, MainLoopTest.DetectsEOF

  [ RUN      ] MainLoopTest.DetectsEOF
   #0 0x0000aaaae2a5c738 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb/unittests/Host/./HostTests+0xa0738)
   #1 0x0000aaaae2a5ac6c llvm::sys::RunSignalHandlers() (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb/unittests/Host/./HostTests+0x9ec6c)
   #2 0x0000aaaae2a5cfdc SignalHandler(int) Signals.cpp:0:0
   #3 0x0000ffff957c0598 (linux-vdso.so.1+0x598)
   #4 0x0000ffff94fcf200 __pthread_kill_implementation ./nptl/./nptl/pthread_kill.c:44:76
   #5 0x0000ffff94f8a67c gsignal ./signal/../sysdeps/posix/raise.c:27:6
   #6 0x0000ffff94f77130 abort ./stdlib/./stdlib/abort.c:81:7
   #7 0x0000aaaae29e52e4 testing::AssertionResult testing::internal::CmpHelperEQ<lldb_private::URI, lldb_private::URI>(char const*, char const*, lldb_private::URI const&, lldb_private::URI const&) (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb/unittests/Host/./HostTests+0x292e4)
   #8 0x0000aaaae2aaa234 lldb_private::FileSystem::Instance() (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb/unittests/Host/./HostTests+0xee234)
   #9 0x0000aaaae2ab2f7c lldb_private::PseudoTerminal::OpenSecondary(int) (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb/unittests/Host/./HostTests+0xf6f7c)
  #10 0x0000aaaae29f5458 MainLoopTest_DetectsEOF_Test::TestBody() (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb/unittests/Host/./HostTests+0x39458)
  #11 0x0000aaaae2a7ae80 testing::Test::Run() (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb/unittests/Host/./HostTests+0xbee80)
  #12 0x0000aaaae2a7c5e4 testing::TestInfo::Run() (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb/unittests/Host/./HostTests+0xc05e4)
  #13 0x0000aaaae2a7cd0c testing::TestSuite::Run() (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb/unittests/Host/./HostTests+0xc0d0c)
  #14 0x0000aaaae2a8a5c0 testing::internal::UnitTestImpl::RunAllTests() (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb/unittests/Host/./HostTests+0xce5c0)
  #15 0x0000aaaae2a89e1c testing::UnitTest::Run() (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb/unittests/Host/./HostTests+0xcde1c)
  #16 0x0000aaaae2a725a4 main (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb/unittests/Host/./HostTests+0xb65a4)
  #17 0x0000ffff94f773fc __libc_start_call_main ./csu/../sysdeps/nptl/libc_start_call_main.h:74:3
  #18 0x0000ffff94f774cc call_init ./csu/../csu/libc-start.c:128:20
  #19 0x0000ffff94f774cc __libc_start_main ./csu/../csu/libc-start.c:379:5
  #20 0x0000aaaae29e3670 _start (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb/unittests/Host/./HostTests+0x27670)

  --
  exit: -6

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152712/new/

https://reviews.llvm.org/D152712