[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

[Leonard Chan via Phabricator via lldb-commits]

leonardchan added a comment.

Hi. I think this is leading to the lldb test failures we're seeing on our linux builder (https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8778187770933863505/+/u/lldb/test/stdout?format=raw):

  ********************
  FAIL: lldb-unit :: Host/./HostTests/13/39 (1722 of 2262)
  ******************** TEST 'lldb-unit :: Host/./HostTests/13/39' FAILED ********************
  Script(shard):
  --
  GTEST_OUTPUT=json:/b/s/w/ir/x/w/staging/llvm_build/tools/lldb/unittests/Host/./HostTests-lldb-unit-1483998-13-39.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=39 GTEST_SHARD_INDEX=13 /b/s/w/ir/x/w/staging/llvm_build/tools/lldb/unittests/Host/./HostTests
  --
  
  Note: This is test shard 14 of 39.
  [==========] Running 2 tests from 2 test suites.
  [----------] Global test environment set-up.
  [----------] 1 test from File
  [ RUN      ] File.GetWaitableHandleFileno
  [       OK ] File.GetWaitableHandleFileno (1 ms)
  [----------] 1 test from File (1 ms total)
  
  [----------] 1 test from TerminalTest
  [ RUN      ] TerminalTest.SetRaw
  /b/s/w/ir/x/w/cipd/bin/../include/c++/v1/optional:1023: assertion this->has_value() failed: optional operator* called on a disengaged value#0 0x0000560219fba7a8 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/b/s/w/ir/x/w/staging/llvm_build/tools/lldb/unittests/Host/./HostTests+0x1417a8)
  
  --
  exit: -6
  --
  shard JSON output does not exist: /b/s/w/ir/x/w/staging/llvm_build/tools/lldb/unittests/Host/./HostTests-lldb-unit-1483998-13-39.json
  ********************

Would you be able to send a fix or revert? Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152712/new/

https://reviews.llvm.org/D152712