[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

[Med Ismail Bennani via Phabricator via lldb-commits]

mib added inline comments.


================
Comment at: lldb/include/lldb/Host/common/ZipFileResolver.h:30
+
+  static bool ResolveBionicPath(const FileSpec &file_spec, FileKind &file_kind,
+                                std::string &file_path,
----------------
mib wrote:
> This function name sounds like the the bionic linker is in the zip file which is not the case IIUC. I'm fine with adding a zip file resolver in lldb but I'd prefer if it had a generic name, otherwise, this should be a plugin.
what about this instead ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152759/new/

https://reviews.llvm.org/D152759