[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest
Greg Clayton via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Jun 15 13:52:41 PDT 2023
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Very easy fix for this as suggested in code changes and this will be good to go
================
Comment at: lldb/source/Plugins/Platform/Android/PlatformAndroid.h:73
+ typedef std::unique_ptr<AdbClient> AdbClientSP;
+ virtual AdbClientSP GetAdbClient();
----------------
Using the "SP" suffix is for std::shared_ptr, "UP" is for unique pointers.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152855/new/
https://reviews.llvm.org/D152855
More information about the lldb-commits
mailing list